New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote apiserver_request_duration_seconds to STABLE #99925
Conversation
Change-Id: I1b050b812738719aedd7ac6f4794ec742812e12d
/sig api-machinery instrumentation |
/lgtm If the buckets need to change in the future, I gather we're allowed to do that. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
This change promotes apiserver_request_duration_seconds to stable metric status.
Change-Id: I1b050b812738719aedd7ac6f4794ec742812e12d
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a common metric used for SLOs/SLIs. We are promoting this to stable status to preserve that intent while shedding less useful dimensions.
Which issue(s) this PR fixes:
Fixes #91536
Special notes for your reviewer:
We went over this in the SIG Api-Machinery meeting and agreed this was appropriate.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: